Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec appears to require gDM leak info on availability of audio #233

Open
eladalon1983 opened this issue Sep 16, 2022 · 2 comments
Open

Spec appears to require gDM leak info on availability of audio #233

eladalon1983 opened this issue Sep 16, 2022 · 2 comments

Comments

@eladalon1983
Copy link
Member

The spec says as follows:

  1. Let requestedMediaTypes be the set of media types in constraints with either a dictionary value or a value of true.

...

  1. Run the following steps in parallel:
    1. For each media type T in requestedMediaTypes,
      1. If no sources of type T are available, reject p with a new DOMException object whose name attribute has the value NotFoundError.
      2. ...
      3. Prompt the user to choose a display device

This appears to require that if audio is requested by the application, and is not available for the user agent to share, then gDM should reject. (Note that this is done before prompting the user. It's not about what the user ultimately chooses.)

Presumably this was added for the perverse case of gDM called on a device with no attached screen and no visible screens, and where tab-capture was not yet supported?

Thanks @shangl for alerting me to this.

@alvestrand
Copy link
Contributor

Should make it clear that requestedMediaTypes checked here is not meant to do audio.

@jan-ivar
Copy link
Member

Should probably only be NotFoundError for video, since audio is optional (mentioned elsewhere in this spec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants