Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests with invalid keyword expect error #226

Closed
rubensworks opened this issue Nov 24, 2019 · 2 comments
Closed

Tests with invalid keyword expect error #226

rubensworks opened this issue Nov 24, 2019 · 2 comments
Labels
propose closing

Comments

@rubensworks
Copy link
Member

If I'm correct, the resolution of w3c/json-ld-syntax#297 was to ignore (and optionally warn) the use of unknown keywords.

However, toRdf tests tpr38 and tpr39 seem to require an invalid IRI mapping error to be thrown. Their description does however mention that such keywords are ignored.

Is this an error in the tests, or is this intentional and am I missing something?
@gkellogg
Copy link
Member

They are errors (both in toRdf and expansion) not because they have the form of a keyword, but because they do not expand to absolute IRIs. IRI expansion returns null and issues a warning when it sees such a keyword, which happens in context processing. Because the value of @reverse must expand to an absolute IRI, this is an error.

@azaroth42
Copy link
Contributor

No issue, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
propose closing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gkellogg @rubensworks @azaroth42