-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate pull requests and issues #35
Comments
Proposal:
For example, a comment would be added to w3cping/tracking-issues#242 such as:
eg. w3cping/tracking-issues#242 could say: [[ Intended benefits:
|
For horizontal folks, it means: When receiving a comment indicating that a pull request is related to a horizontal issue, consider adding a link to that pull request to the link(s) listed in the initial of that horizontal issue. If the horizontal tracker issue has "needs-resolution", consider adding "tracker" after the link unless you'd like the Director to block on it if it's not merged. |
If we need to downgrade an issue (from -needs-resolution to -tracker), that creates a larger number of touchpoints that we'll have to fix between runs of the tool, since we'll presumably need to also downgrade all of the linked PRs. Not necessarily a showstopper, just calling out the edge case. |
I'm not sure I understand how this would look like / work in practice, but the idea seems good. I already manually cross reference issues and pull requests, but it would be good for those relationships to be more visible. |
indeed. Just curious, how often does this case occur? If it is common, I could think of ways to optimize it. |
I agree that the issue of a PR or issue changing its state is potentially problematic. I bet that changes for the main issue might not happen a lot (if at all), but for "maybe related PRs", it is likely, so we can have mismatchs here. |
If an issue is created, it may get resolved through one or more pull requests. It would be nice to have a single entry for the issue and the PR in the horizontal tracker.
For example,
w3c/ambient-light#63
resulted in 2 pull requests:
w3c/ambient-light#77
w3c/sensors#429
from @xfq
The text was updated successfully, but these errors were encountered: