Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to edit 1.2 Test Cases #247

Closed
HolgerKnublauch opened this issue Feb 13, 2025 · 3 comments · Fixed by #248
Closed

Where to edit 1.2 Test Cases #247

HolgerKnublauch opened this issue Feb 13, 2025 · 3 comments · Fixed by #248

Comments

@HolgerKnublauch
Copy link
Contributor

The test suite produced by the old WG is here

https://github.com/w3c/data-shapes/tree/gh-pages/data-shapes-test-suite/tests

Whenever we add new features or make other changes for 1.2, the PRs should include one or more test cases as those help clarify the semantics.

We need to decide where to put those new tests.

  1. We could add them to the existing folders, with some annotation property that the tests are 1.2 specific. The problem here is that the 1.0 documents are pointing at the very same folder on GitHub, and there is a risk that ongoing work will produce temporary noise and confusion.

  2. We could start with a clone of the old test cases into something like shacl12-tests so that they evolve independently until the 1.2 release.

How is this handled by other groups? Does anyone see problems with option 2?

@TallTed
Copy link
Member

TallTed commented Feb 13, 2025

Something like option 2 should work. fwiw, RDF-star WG is now maintaining one test directory for each version ( 1.0 | 1.1 | 1.2 ) of each spec ( rdf-concepts | rdf-semantics | etc.)

@ajnelson-nist
Copy link

@TallTed , I like the notion of keeping separate test directories. But, where are the examples that you cited? I couldn't see per-version test directories in this repositories:

@HolgerKnublauch , how would the tests be arranged (1) while SHACL 1.2 is in progress, and (2) once SHACL 1.2 is finished?

@HolgerKnublauch
Copy link
Contributor Author

Ok I have created a PR with a copy of the test cases from 1.0 into shacl12-test-suite. I have left out the HTML file for now but prior to publishing we could decide whether we want to upgrade the existing folder with the new tests or create a new publication.

I hope the folder name and readme clarify that these tests are for 1.2 under development only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants