Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC pinning broken #2601

Closed
yatil opened this issue Feb 9, 2023 · 3 comments
Closed

TOC pinning broken #2601

yatil opened this issue Feb 9, 2023 · 3 comments
Assignees
Labels
bug Code defects; not for inaccurate prose Site Design Related to design of the APG site on w3.org built during 2021 redesign project

Comments

@yatil
Copy link

yatil commented Feb 9, 2023

In certain viewport sizes, the TOC is pinned to the top but fills the whole horizontal space, making it hard for users to read the content.

This is likely due to the mixed used of em-based media queries (for the general site template) and px-based media queries (for styles specific to the aria practices guide).

Here’s a video of the behavior:

Screenshot.2023-02-09.at.11.08.59.mp4
@mcking65
Copy link
Contributor

@alflennik

I think we may have another report of this issue in #2669.

Do you have a PR for the fix? Do I recall correctly that this is a quick fix?

@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Apr 10, 2023
@alflennik
Copy link
Contributor

@mcking65 thank you for putting this back on our radar, I was under the impression that we had already fixed all the media queries to use the same em values as the template but in this case we're still using a px value. Yes, the linked issue #2669 is the same as this one.

@a11ydoer
Copy link
Contributor

@mcking65 I confirmed that pinned TOC was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Site Design Related to design of the APG site on w3.org built during 2021 redesign project
Projects
None yet
Development

No branches or pull requests

4 participants