Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping initServiceWorkerMessageEvent() #701

Closed
bashi opened this issue May 20, 2015 · 3 comments
Closed

Consider dropping initServiceWorkerMessageEvent() #701

bashi opened this issue May 20, 2015 · 3 comments

Comments

@bashi
Copy link

bashi commented May 20, 2015

ServiceWorkerMessageEvent has initServiceWorkerMessageEvent() [1], but I think we should drop this method because as the note[2] says, initEvent() method only exists for historical reason and we can use constructor to initialize events.

[1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworkermessage-event-initserviceworkermessageevent-method
[2] https://dom.spec.whatwg.org/#dom-event-initeventtype-bubbles-cancelable

@jungkees
Copy link
Collaborator

Agreed. @jakearchibald @annevk Can there be any concern about dropping this method considering devs historically having used the initMessageEvent()? (Although they're now defined as unrelated interfaces.)

@domenic
Copy link
Contributor

domenic commented May 20, 2015

+1, new events should not have this

@jungkees
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@bashi @domenic @jungkees and others