Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling for aborted streams feeding a navigation request #1184

Open
wanderview opened this issue Aug 9, 2017 · 3 comments
Open

error handling for aborted streams feeding a navigation request #1184

wanderview opened this issue Aug 9, 2017 · 3 comments

Comments

@wanderview
Copy link
Member

This demo streams data every 1 second from a service worker infinitely:

https://html-sw-stream.glitch.me/

Chrome will currently eventually time out the service worker. When this happens the partially rendered iframe is just left.

Aside from the question in #1182, should aborting the service worker in the middle of the stream leave the partially rendered data? Should we not show an error here?

@jakearchibald
Copy link
Contributor

What do we do without a service worker in these cases? I thought we still show partial data if the connection terminates.

@wanderview
Copy link
Member Author

I tried running edge 16 through this test, but it doesn't seem to stream data for any of the iframes.

@wanderview
Copy link
Member Author

wanderview commented Nov 3, 2017

I retested in FF58 and chrome 61. I left them both up for 10+ minutes:

Chrome:

  • No service worker iframe continues to stream without timeout
  • Service worker iframe with server stream times out at 330 seconds
  • Service worker iframe with js stream times out at 330 seconds

Firefox:

  • No service worker iframe continues to stream without timeout
  • Service worker iframe with server stream continues to stream without timeout
  • Service worker iframe with js stream times out at 330 seconds

In both browsers the "timeout" leaves the iframe with partial data.

I guess maybe the original issue is moot since we are aligned now.

Do we care about the difference in the middle iframe? I think the FF behavior is due to us bypassing the SW completely for the data copying in that case which means killing the SW doesn't have any effect. That may change with our multi-process refactor (if the process is killed, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants