Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using checkbox in long data-tables with ripple enabled has serious performance issues in Chrome #2574

Closed
shig2k1 opened this issue Nov 20, 2017 · 4 comments
Labels
invalid The issue is missing information or is not a valid bug/feature request

Comments

@shig2k1
Copy link

shig2k1 commented Nov 20, 2017

New Functionality

Try creating a v-data-table with v-checkboxes in it. After 150 rows the performance in Chrome / Chromium is seriously affected. Removing ripple effect and it's peachy

Improvements

I won't have to bugger about overriding the css

Bugs or Edge Cases it Helps Avoid

Serious performance issues in Chrome / Chromium. Yes, I'm aware that pagination would help, it's not always convenient to split longer lists.

@shig2k1
Copy link
Author

shig2k1 commented Nov 20, 2017

I should also add - Vuetify is AMAZING! you all should be so proud of your work

@shig2k1
Copy link
Author

shig2k1 commented Nov 20, 2017

On closer inspection, I can simply improve performance in Chrome/chromium by adding the following override:

.input-group--selection-controls__ripple {
border-radius: 0 !important;
}

performance afterwards is fine.

@KaelWD
Copy link
Member

KaelWD commented Nov 20, 2017

This looks like it's supposed to be a bug report. Please open a new issue with the required information and provide some reproduction.

I made this codepen with 500 rows: https://codepen.io/anon/pen/XzZmMz?editors=1010
The only performance issue I can see is when data changes, caused by vuejs/vue#6351

@KaelWD KaelWD closed this as completed Nov 20, 2017
@KaelWD KaelWD added the invalid The issue is missing information or is not a valid bug/feature request label Nov 20, 2017
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid The issue is missing information or is not a valid bug/feature request
Projects
None yet
Development

No branches or pull requests

2 participants