Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBadge): restore unused SASS variables #20709

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

J-Sek
Copy link
Contributor

@J-Sek J-Sek commented Nov 16, 2024

Description

Applies $badge-font-family and $badge-icon-padding. Both were not used after migration from v2 to v3. I assume it was not intentional.

resolves #19834

Markup:

Demo on Stackblitz

@J-Sek J-Sek added T: bug Functionality that does not work as intended/expected C: VBadge VBadge labels Nov 16, 2024
@J-Sek J-Sek self-assigned this Nov 16, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Nov 20, 2024
@KaelWD KaelWD merged commit fd844e1 into vuetifyjs:master Nov 20, 2024
10 checks passed
@J-Sek J-Sek deleted the fix/vbadge-19834 branch November 20, 2024 09:07
KaelWD pushed a commit to J-Sek/vuetify that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBadge VBadge T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.6.3] Badge does not use $badge-font-family
2 participants