Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendable Elasticsearch queries #3934

Closed
2 of 7 tasks
Fifciu opened this issue Dec 19, 2019 · 2 comments
Closed
2 of 7 tasks

Extendable Elasticsearch queries #3934

Fifciu opened this issue Dec 19, 2019 · 2 comments
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority
Milestone

Comments

@Fifciu
Copy link
Collaborator

Fifciu commented Dec 19, 2019

What is the motivation for adding / enhancing this feature?

When we are working on more advanced projects. We always need to create some custom stuff in ES queries. Custom aggregations, faceted filters or whole queries, e.g. for category view. It would be amazing if we could easily modify them (maybe from module?). Currently, it requires workarounds which is not a pleasure.

There should be some well-documented standards for that.

I think we should discuss about possibilities and ideas because it looks like big and so useful thing.

What are the acceptance criteria

  • Standard for extending queries that VSF uses internally (maybe as one of new hooks?)
  • Well documentation of that with use cases (it is essential)

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
@Fifciu Fifciu added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Dec 19, 2019
@pkarw pkarw added the P3: Normal Priority mark - normal priority label Dec 25, 2019
@pkarw pkarw added this to the 1.12.0-rc1 milestone Dec 25, 2019
@pablogiralt
Copy link

+1

@pkarw pkarw closed this as completed May 15, 2020
@pkarw pkarw reopened this May 15, 2020
@gibkigonzo
Copy link
Contributor

there is an option to extend it by adding custom filter in storefront-query-builder vuestorefront/storefront-query-builder#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority
Projects
None yet
Development

No branches or pull requests

4 participants