Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

[FEATURE] always use translated object to get the text fields' value #1246

Closed
2 tasks
mkucmus opened this issue Nov 19, 2020 · 0 comments · Fixed by #1262
Closed
2 tasks

[FEATURE] always use translated object to get the text fields' value #1246

mkucmus opened this issue Nov 19, 2020 · 0 comments · Fixed by #1262
Assignees
Milestone

Comments

@mkucmus
Copy link
Collaborator

mkucmus commented Nov 19, 2020

Description

almost every entity has a translated object which contains the translatable text fields inside.
it looks like:

{
 ...
 name: "black",
 description: "black color",
 translated: {
   name: "schwarz",
   description: "schwarz Farbe"
  }
}

unfortunately, sometimes the main properties have nullish value, but not the translated one! they are always filled out with the correct values.

So de goal is to always get the translated one to avoid further issues related to falsy values.

Acceptance criteria

  • all the packages are checked for places when the text values are being extracted - like product.name
  • replace all the occurrences with the translated way
@mkucmus mkucmus added this to the v0.6.0 milestone Nov 19, 2020
@mkucmus mkucmus self-assigned this Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant