Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: ability to use another theme #1163

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Oct 6, 2020

Changes

related: #1158

The feature allows using another theme as a base, by simply putting its name into shopware-pwa.config.js file like this:

module.exports = {
  shopwareEndpoint: 'https://pwa-demo-api.shopware.com',
  shopwareAccessToken: 'SWSC40-LJTNO6COUEN7CJMXKLA',
  // theme: '@shopware-pwa/default-theme',
  theme: 'my-theme',
}
  1. It looks by path, so rootDirectory/path
  2. If not found it looks in node modules

Preferably theme should be placed in node_modules so published as NPM package.

Next things to do with the task is to add tools for theme building.

Checklist

@patzick patzick requested a review from mkucmus October 6, 2020 16:21
@vercel
Copy link

vercel bot commented Oct 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/4v1bg5evk
✅ Preview: https://shopware-pwa-docs-git-feat-ability-to-use-another-theme.shopware-pwa.vercel.app

@patzick patzick changed the title Feat/ability to use another theme feat: ability to use another theme Oct 6, 2020
@vercel vercel bot temporarily deployed to preview October 7, 2020 06:58 Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

💙 shopware-pwa-canary successfully deployed at https://eb33d71baf2d732b2dc87ed057bcb50144682eec.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@mkucmus mkucmus merged commit bbdd8f4 into master Oct 7, 2020
@mkucmus mkucmus deleted the feat/ability-to-use-another-theme branch October 7, 2020 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants