Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

[BUG] Linting/formatting of vue components #1136

Closed
niklaswolf opened this issue Sep 25, 2020 · 2 comments · Fixed by #1563
Closed

[BUG] Linting/formatting of vue components #1136

niklaswolf opened this issue Sep 25, 2020 · 2 comments · Fixed by #1563
Assignees
Labels
bug Something isn't working
Milestone

Comments

@niklaswolf
Copy link
Collaborator

Describe the bug

Besides being set up as git hook, the formatting doesn't seem to be applied. All vue components in default-theme are not formatted according to prettierrc. For example there are double quotes everywhere besides single quotes being configured in prettierrc.

It's just a small issue, but it's a bit annoying because IF you have setup formatting/linting in your IDE every overridden component gets formatted according to prettierrc. That does make updating/comparing overridden components to their original more difficult than it needs to be, because you get all these formatting differences.

I like to propose, that all components get formatted according to prettierrc, alternatively the configuration of prettier should at least match the current formatting style.

Additional context

https://github.com/DivanteLtd/shopware-pwa/blob/master/packages/default-theme/.prettierrc

@niklaswolf niklaswolf added the bug Something isn't working label Sep 25, 2020
@mkucmus mkucmus self-assigned this Oct 6, 2020
@patzick
Copy link
Collaborator

patzick commented Jun 16, 2021

I think this one is already done, @niklaswolf can you confirm?

@patzick patzick added the awaiting user response Issue is waiting for the author or participant to take an action. label Jun 16, 2021
@niklaswolf
Copy link
Collaborator Author

@patzick I think the prettier config in the project template caused the issue, because it had other configurations than the one in default-theme

@patzick patzick removed the awaiting user response Issue is waiting for the author or participant to take an action. label Jun 16, 2021
@patzick patzick added this to the v0.9.1 milestone Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants