You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Besides being set up as git hook, the formatting doesn't seem to be applied. All vue components in default-theme are not formatted according to prettierrc. For example there are double quotes everywhere besides single quotes being configured in prettierrc.
It's just a small issue, but it's a bit annoying because IF you have setup formatting/linting in your IDE every overridden component gets formatted according to prettierrc. That does make updating/comparing overridden components to their original more difficult than it needs to be, because you get all these formatting differences.
I like to propose, that all components get formatted according to prettierrc, alternatively the configuration of prettier should at least match the current formatting style.
Describe the bug
Besides being set up as git hook, the formatting doesn't seem to be applied. All vue components in default-theme are not formatted according to prettierrc. For example there are double quotes everywhere besides single quotes being configured in prettierrc.
It's just a small issue, but it's a bit annoying because IF you have setup formatting/linting in your IDE every overridden component gets formatted according to prettierrc. That does make updating/comparing overridden components to their original more difficult than it needs to be, because you get all these formatting differences.
I like to propose, that all components get formatted according to prettierrc, alternatively the configuration of prettier should at least match the current formatting style.
Additional context
https://github.com/DivanteLtd/shopware-pwa/blob/master/packages/default-theme/.prettierrc
The text was updated successfully, but these errors were encountered: