Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

[BUG] PersonalDetailsGuestForm is not working when creating a new account #1125

Closed
fsavina opened this issue Sep 22, 2020 · 6 comments · Fixed by #1223
Closed

[BUG] PersonalDetailsGuestForm is not working when creating a new account #1125

fsavina opened this issue Sep 22, 2020 · 6 comments · Fixed by #1223
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fsavina
Copy link

fsavina commented Sep 22, 2020

this.customer is undefined in the toShipping method in PersonalDetailsGuestForm.vue causing a bug when you try to access the shipping step while creating a new account

https://github.com/DivanteLtd/shopware-pwa/blob/e729c2407c09d7928719c0c8eeb01f7313524fba/packages/default-theme/components/checkout/steps/guest/PersonalDetailsGuestForm.vue#L278

@fsavina fsavina added the bug Something isn't working label Sep 22, 2020
@fsavina
Copy link
Author

fsavina commented Sep 22, 2020

shopware-pwa version: canary
SW version: v6.3.0.2

@mkucmus mkucmus self-assigned this Oct 30, 2020
@mkucmus mkucmus added this to the v0.6.0 milestone Oct 30, 2020
@mkucmus mkucmus modified the milestones: v0.6.0, v0.5.1 Oct 30, 2020
@mkucmus
Copy link
Collaborator

mkucmus commented Nov 4, 2020

@fsavina is it still an issue? I have checked it today, but the shopware-pwa@canary is too new I guess, and it just does not happen

@fsavina
Copy link
Author

fsavina commented Nov 4, 2020

Honestly, I've no idea. We haven't been upgrading the shopware-pwa package for weeks now because we've overridden 2/3 of the code and there's no point in upgrading it anymore

@fsavina
Copy link
Author

fsavina commented Nov 4, 2020

@mkucmus feel free to close the ticket if you are not able to reproduce the bug. I've fixed it a while ago in my overriden component

@mkucmus
Copy link
Collaborator

mkucmus commented Nov 4, 2020

thanks for the feedback, @fsavina one more thing: is it possible to list the main reasons why you override 2/3 of the code? Is the project you are currently working on that customized or the default-theme is not what you want at all ? ;)

@mkucmus mkucmus closed this as completed Nov 4, 2020
@fsavina
Copy link
Author

fsavina commented Nov 4, 2020

No worries.
I don't recall all of the reasons but some of them are:

  • most of the texts are hardcoded in the components and we needed to move them to the snippets in order to translate them;
  • several calls to the API in the shopware client are not customizable;
  • some features where not implement (ie. adding a promotion code to the cart in the checkout steps);
  • the lack of use of Vue slots in the components to customize their layout (storefront-ui components instead offer a great degree of customizability);
  • some unresolved bugs like the one in this ticket;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants