Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-comment): support more Giscus built-in themes #351

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

SuniRein
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

Providing more Giscus built-in themes.

Screenshots

Before

After

@Mister-Hope Mister-Hope merged commit 7f224df into vuepress:main Feb 12, 2025
17 checks passed
@Mister-Hope
Copy link
Member

Btw, can you check locales as well? If there are new locale support added, it would be great to add them as well.

@SuniRein
Copy link
Contributor Author

Sure. See #352

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13268375905

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on main at 59.656%

Totals Coverage Status
Change from base Build 13259810273: 59.7%
Covered Lines: 1349
Relevant Lines: 2044

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants