Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar's messy layout at narrow screen #714

Merged
merged 4 commits into from
Aug 8, 2018
Merged

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Aug 8, 2018

Summary

Solve the navbar's messy layout under the narrow screen, also a replacement of #266

Here's an optimization point that we can continue to do. When navbar's links are too long, some nav links on the right side may not be visible. But at the moment I have not come up with a good solution, or the solution I came up with is more complicated. The current proposal is to control the width of the sidebar.

Before

before

After

after

cc @chrisvfritz

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ulivz ulivz merged commit 3e1da57 into master Aug 8, 2018
@ulivz ulivz deleted the navbar-layout-enhancement branch August 9, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant