Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming themedir/index.js #223

Closed
mdaffin opened this issue Apr 23, 2018 · 2 comments
Closed

Consider renaming themedir/index.js #223

mdaffin opened this issue Apr 23, 2018 · 2 comments

Comments

@mdaffin
Copy link
Contributor

mdaffin commented Apr 23, 2018

#154 was recently merged but with the discussions about introducing a server-side plugin framework (being discussed in #198), we may want to consider renaming the themeDir/index.js in prepare.js L162 to something else if we decide we want to use that for the server side plugins instead. If we do this then we can treat the themeDir as just another plugin rather then having to special case it.

If we release the next version as is then this will be a lot harder to change in the future.

Proposals:

  • enhanceApp.js - consistent with the .vuepress/enahnceApp.js.
  • themeApp.js
  • themeEnhanceApp.js - consistent with internal naming.
  • app.js
  • client.js

We might also consider if we want to add client-side support to the plugins (so plugins can add components, for example, #143 could just be a plugin).

@yyx990803
Copy link
Member

Yeah, changed to enhanceApp.js in b668875

@mdaffin
Copy link
Contributor Author

mdaffin commented Apr 23, 2018

It is still index.js on master (and in that commit). It looks like you changed the temp file not the source file in prepare.js on L178 - I have created #226 which corrects this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants