Wrong "Edit in github" url with Permalinks.

[mathieutu]

• I confirm that this is an issue rather than a question.

Bug report

Version

1.0.0-alpha.43

Steps to reproduce

What is expected?

When setting a permalink configuration and clicking on the "edit on github" link, the link should target the right place of the page in the repo.

What is actually happening?

The link is wrong, and target the permalink path.

Other relevant information

I've also the blog plugin.

[YunYouJun]

Can you provide more config information?

This is my config, and it works.

module.exports = {
  themeConfig: {
    repo: 'YunYouJun/software-engineering-note',
    docsDir: 'docs',
    editLinks: true,
    editLinkText: 'Edit in GitHub'
  }
}

[shigma]

You should provide more details. What is your themeConfig and what is this "wrong link"?

[mathieutu]

my concerned config is:

permalink: ':year/:slug',
themeConfig: {
    repo: 'mathieutu/blog',
    repoLabel: 'GitHub',
    editLinks: true,
}

And the problem is that in the "edit link" the permalink path is used instead of the real file path:

If I set permalink: false the url is ok:

[shigma]

This issue will be fixed by #1419 😄

[mathieutu]

ok thanks!

[ulivz]

Fixed at #1419