Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix blog plugin path bug #1420

Merged
merged 1 commit into from
Mar 12, 2019
Merged

fix: fix blog plugin path bug #1420

merged 1 commit into from
Mar 12, 2019

Conversation

yyyanghj
Copy link
Contributor

@yyyanghj yyyanghj commented Mar 8, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@yyyanghj
Copy link
Contributor Author

yyyanghj commented Mar 8, 2019

Make sure that the path of the tag and category pages is the same as parent's path

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but FYI we're planning to restructure our blog plugin before we finalize alpha stage, so the old blog plugin could be deprecated, here is the RFC : #1412.

@ulivz ulivz merged commit 5c0e62f into vuejs:master Mar 12, 2019
@yyyanghj
Copy link
Contributor Author

Thanks, but FYI we're planning to restructure our blog plugin before we finalize alpha stage, so the old blog plugin could be deprecated, here is the RFC : #1412.

That would be better

@yyyanghj yyyanghj deleted the fix-plugin-blog branch March 13, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants