Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default viewport settings affect UX badly #110

Closed
pepelsbey opened this issue Apr 17, 2018 · 1 comment
Closed

Default viewport settings affect UX badly #110

pepelsbey opened this issue Apr 17, 2018 · 1 comment

Comments

@pepelsbey
Copy link

pepelsbey commented Apr 17, 2018 •
edited
Loading

By default there’s a viewport configuration that considered an antipattern:

<meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no">

The maximum-scale=1 and user-scalable=no are locking viewport scaling which affects UX and accessibility badly. See Anti-Pattern: Disabling Pinch-to-Zoom by eBay for details.

I’m ready to send PR removing those viewport options, but I decided to check if you’d agree.
@yyx990803
Copy link
Member

Yeah we can remove them for accessibility.

@smori1983 smori1983 mentioned this issue Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pepelsbey @yyx990803