perf: improve ssr performance #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
approved these changes
Dec 12, 2018
| @@ -2,6 +2,10 @@ import SmoothScroll from 'smooth-scroll/dist/smooth-scroll.js' | |||
|
|
|||
| export default { | |||
| created () { | |||
| if (this.$ssrContext) { | |||
There was a problem hiding this comment.
Actually this file has been removed for now since we deprecated smooth scroll.
| @@ -128,12 +126,14 @@ export function resolveSidebarItems (page, regularPath, site, localePath) { | |||
| } | |||
|
|
|||
| const sidebarConfig = localeConfig.sidebar || themeConfig.sidebar | |||
| let normalizedPagesMap = {} | |||
| pages.forEach(page => normalizedPagesMap[normalize(page.regularPath)] = page); | |||
There was a problem hiding this comment.
Maybe following style would be more refreshing:
const normalizedPagesMap = pages.reduce((map, page) => map[normalize(page.regularPath)] = page, {})
|
@ulivz i'll update the PR tomorrow |
janvennemann
changed the title
ulivz
reviewed
Dec 13, 2018
|
@ulivz fixed! |
sullivanpt
reviewed
Dec 29, 2018
| path: ensureExt(pages[i].path) | ||
| }) | ||
| } | ||
| if (path in pages) { |
There was a problem hiding this comment.
This changes the function signature but doesn't update all the callers. resolvePage is also called from the default theme. See vuepress/packages/@vuepress/theme-default/components/Page.vue computed.prev. which is now broken and gives an error when trying to use frontmatter prev / next links. See #1140 for a primitive fix. Thanks.
sullivanpt
added a commit
to sullivanpt/vuepress
that referenced
this pull request
Dec 29, 2018
fixes bug introduced with vuejs#1068.
18 tasks
|
Reverted this change at b24c317 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve ssr performance by caching items when resolving sidebar items. Fix memory leak in root mixins.
What kind of change does this PR introduce? (check at least one)
We are testing VuePress on a huge API documentation which currently has over 400 pages. 200 of those pages are reachable via the sidebar in different sidebar groups. We experienced very slow build times (ranging from 300 - 800ms per page) and crashes due to heap out of memory.
After a little investigation we identified that resolving of sidebar items is responsible for slow build times. This introduces a simple map that stores page objects for each normalized path for faster lookups. The build times are now back to a reasonable 50-100ms for each page.
The crash was caused by the
updateLoadingStatemixin, which apparently contains client only code that does not make much sense to run on the server. The event handler bindings in that mixin will lead to a memory leak since the components will never be released.Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
Other information:
Tested on Node v10.13.0
#966 may be related.
For a reproducible test case, clone https://github.com/appcelerator/titanium-vuepress-docs and build with
npm run docs:build