cli-plugin-unit-jest indirectly depends on an old version of core-js

[sirlancelot]

Version

4.1.2

Environment info

System:
    OS: macOS Mojave 10.14.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
    Yarn: Not Found
    npm: 6.13.4 - ~/.nvm/versions/node/v10.16.3/bin/npm
  Browsers:
    Chrome: 79.0.3945.130
    Firefox: 72.0.2
    Safari: 13.0.5
  npmPackages:
    @vue/cli-plugin-unit-jest: 4.1.2 => 4.1.2
    ... a lot ...

Steps to reproduce

Start a new Vue CLI project
Include Jest tests
Install packages
Observe the dependency tree

What is expected?

core-js@2 should not get installed

What is actually happening?

core-js@2 is getting installed via the following dependency chain:

$ npm ls core-js@2
vue-cli-project@1.1.0 ~/Git/vue-cli-project
└─┬ @vue/cli-plugin-unit-jest@4.1.2
  └─┬ babel-plugin-transform-es2015-modules-commonjs@6.26.2
    └─┬ babel-runtime@6.26.0
      └── core-js@2.6.11 

---

The rest of the project uses core-js@3 properly, this is the only package which brings in the older version.

[LinusBorg]

Hm. It's possible that this is an orphaned dependency that we forgot to remove.

We already have @babel/transform-modules-commonjs which I think is the babel7-comparible successor to the outdated package in question.

This would also explain why it doesn't crate any problems so far: it is simply never used, and corejs2 isn't either.

@sodatea did I miss some weird compatibility reason that this dependency might still be in there for, or can we remove it?

[haoqunjiang]

It's for https://github.com/vuejs/vue-jest

[haoqunjiang]

We use the stable v3.0.4 of vue-jest https://github.com/vuejs/vue-jest/tree/v3.0.4
I'm not sure if its inline config works with babel 7 plugins.

[sirlancelot]

I thought I'd bring it up because I'm getting a deprecation notice when I install now. Is this the right project or should it be moved to vue-jest?

$ npm i
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

[benjamin-t-frost]

I'm still getting this. Any plans to sort it?