-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed behaviour for meta #2319
Comments
There are indeed a lot of edge cases that are not covered with this stricter meta so let's revert it for now and figure out a better approach in the future |
Still running into type break updating from 4.4.0 to 4.4.2, haven't root caused yet, but code has worked that way for 3 months.
|
@WarpedPixel This issue is unrelated. I think you were searching for #2321 |
Reproduction
https://play.vuejs.org/#eNqlVVtv2zYU/itn6gA7WCw6btEHzfWSFkWzYu2KZNtL1Qdaom0mFCmQlOPA8H/fIalr7BZo68SwdC7fufLjPiool/GdiZKIF6XSFvaQaUYtuypLOMBKqwJG24qNUlkbaFVZpmtNTMJrp3Z+jY6WZRx8U9mijvF7lkqAuDJsHNzDe6EqacejZ+g2OovOo9odc5tbVpQC/RfOcL65WFwzIZQL9suc4KsXl/4HH4zVSq4XbyqtmawzhpLaTTIntQ72e/jVK+JVJcQnVMLh4GFIwJlLum0Ab3yWf3F5D1a9SiOSRot3Cp/hWhVsTjr9Vz3oEiWt25V7O/Kbkybm3M1liPUfZw9AartaPSdtY7BfoZexPTHND6xQ+vGaG4s/57Uw4PanPGmn2c7TFehDN0NtBPVkm7G7ggZ2rWRouAcf9oZlSuc39OFU+N9d/JxlgmoGhcorwQZ62LsuEAJScWlKllmuJLy//VfiSuXvhFpScftYLJUwzpBLdFrRjIXQH5ilAQHAcitYArgUXK4xrJNteM5eY4PyTFfF0vyRwFIpwaj0etwR/Md9VtLUq2WSYUmfv8Ar+OyM92HrYERG2HSFHZC4kEnb1HMoMJkE7epERk6Dtk9ySMDqimGrDudDWL9VQ+y278fgXjXqYEK9LZa2PBPMOLgNFzmenSSU4T61cc9h5EHCp47UCdrWjq4a2E4ZwocPTvGjsmA3DGhmKypgi7l3+lOVNdoO5zg7kvC8n+GPxPmuAk/W5xkF4Eu9Ofg72ByNi9I/i2MfYBOOaXLq7I7PPHbYO3w8IHWmku382crZilaiwUZG6J9VR6Mm07y0YJitShBUrpGZrEFWclQSlPiIL0/4drZokJBtZ0fEMzjqPxenhToZKHDIpKAl3llKYijfsLRWYIR2RmnUEYYTp9HG2tIkhFSyvF/HOG/SWVy+iJ/HU5Jjk3vSmJlistTqweDzHaLXc02jSzQiOdtaZAYzoSX/Wogjw8uX8cv4ggi+JIhOOPLczmM35IJlWoM7suLrJ0W6FeWC6b9Lx3fDYilehw/vvcxRRZtotmHZ/Qn5ndmFlD9phtVtWa84S/Wa4V3l1G9vP7IdPrfKQMffVN4wo0TlcgxmryuZY9o9O5/tn35myLv/mLc7y6RpinKJ+m54ez/IN98ovUv3efyi10VjH5F24sy4+xAvVuRDvDWD3xKZmukEZuUOMFmew7PpdOoJvkA4LidLZa0qEriYljsvL2meY7KtxN8CCAsLoPAbfj1w7S3YComkb7mZ9SN38F0CWZb1Ekhgin+zGiE6/A/dvDHF
Steps to reproduce the bug
Existing route configuration in TypeScript. There's an interface
RouteMeta
that has both required and optional fields. Some routes havemeta
defined, some have not. The ones that don't havemeta
defined are parent routes without their own component.Expected behavior
In vue-router 4.4.0 this passed the build
Actual behavior
In vue-router 4.4.1 meta became required when at least one field is required. Now I either have to make all fields in RouteMeta optional or add dummy meta to the routes without their own rendering component.
This is a breaking change in a patch version.
Additional information
No response
The text was updated successfully, but these errors were encountered: