Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router View and Suspense together break Reactivity #1114

Closed
Subwaytime opened this issue Sep 10, 2021 · 6 comments
Closed

Router View and Suspense together break Reactivity #1114

Subwaytime opened this issue Sep 10, 2021 · 6 comments
Labels
bug Something isn't working external This depends on an external dependency but is kept opened to track it help wanted Extra attention is needed

Comments

@Subwaytime
Copy link

Version

4.0.11

Reproduction link

github.com

As seen in this other reproduction via sfc created by @skirtles-code, this does only occur when router-view is added not on suspense only.

Steps to reproduce

Using suspense and router-view as mentioned from the official Vue 3 Docs it runs into the issue that an increasing counter loses all reactivity inside the #fallback area of suspense. Without router-view everything works fine.

What is expected?

Expected is that any variable (prop, ref etc) is holds its reactivity inside the #fallback slot same as default area. With or without router-view.

What is actually happening?

Adding router-view around suspense breaks reactivity on #fallback slot.

@posva
Copy link
Member

posva commented Sep 10, 2021

Can you create a new git repo without the node_modules folder?

@posva posva added the needs reproduction This bug hasn't provided a valid reproduction for the bug to be verified label Sep 10, 2021
@Subwaytime
Copy link
Author

Oh sorry! Didnt see that it got commited, let me just remove them quickly!

@Subwaytime
Copy link
Author

Its cleaned up now! Same Repo, with gitignore and npmignore. Sorry for the inconvenience

@posva
Copy link
Member

posva commented Sep 10, 2021

Your package.json doesn't have any deps, can you create a proper project with vite to show the problem?

@Subwaytime
Copy link
Author

Subwaytime commented Sep 10, 2021

Uff sorry again, having a bad day! Updated the packages now! It runs with the newest vite version, vue-router and vue 3.

@posva posva added bug Something isn't working external This depends on an external dependency but is kept opened to track it help wanted Extra attention is needed and removed needs reproduction This bug hasn't provided a valid reproduction for the bug to be verified labels Sep 10, 2021
@posva
Copy link
Member

posva commented Sep 16, 2021

Fixed un Vue

@posva posva closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external This depends on an external dependency but is kept opened to track it help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants