Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom file go to definition #102

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

zqran
Copy link
Contributor

@zqran zqran commented Jun 20, 2023

Screenshots

2023-06-21.12.22.33.mov

@johnsoncodehk
Copy link
Member

Thanks for the PR! But I think goto definition selection is broken.
https://github.com/vuejs/repl/assets/16279759/fcb6a5d4-ed76-4ca1-af96-3e5df7b3b6a7

@zqran
Copy link
Contributor Author

zqran commented Jun 22, 2023

Thanks for the PR! But I think goto definition selection is broken. https://github.com/vuejs/repl/assets/16279759/fcb6a5d4-ed76-4ca1-af96-3e5df7b3b6a7

Fixed!

@yyx990803 yyx990803 merged commit 48e1e0f into vuejs:main Jun 22, 2023
@zqran zqran deleted the 0621-go-to-definition branch June 22, 2023 07:42
@zqran zqran changed the title feat: support custom file go to difinition feat: support custom file go to definition Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants