Double click to show all occurrences in scrollbar is broken #4850

johuhype · 2024-09-17T10:23:12Z

Vue - Official extension or vue-tsc version

2.1.6

VSCode version

1.93.1

Vue version

2.7.16

TypeScript version

5.5.4 / 5.6.2

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
    Memory: 28.76 GB / 47.81 GB
  Binaries:
    Node: 20.17.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.10.0 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.3527

package.json dependencies

No response

Steps to reproduce

Double click the name of a function in a .vue file. Previously, all occurrences were highlighted in the scrollbar of VS code.
Now the highlighting in the scrollbar is missing and can only be seen in the document.

When I double click the name of a function in a .ts file, scrollbar highlighting is still working as expected.

What is expected?

Show highlighting for occurrences in scrollbar

What is actually happening?

Highlighting is missing

Link to minimal reproduction

No response

Any additional comments?

No response

romansp · 2024-09-19T17:40:05Z

Noticed something similar as well. Though it's for single click occurrences highlight.

This feature is controlled via editor.occurrencesHighlight VS Code setting. After additional investigation:

"editor.occurrencesHighlight": "single" - works in .ts files, doesn't work in .vue files
"editor.occurrencesHighlight": "multiFile" - works in .ts and .vue files

VS Code:

Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

Vue Extension v2.1.6.
TS: 5.5.4, Hybrid mode enabled

Anything else I can provide to help resolve this?

ddenev · 2024-09-22T09:30:53Z

Some additional findings re the "single click occurrence highlight":

this stops working intermittently - I cannot find a pattern when it stops working. sometimes it's when I open a .vue file, sometimes its when I open vscode
toggling the editor.occurrencesHighlight option from multiFile to single and back seems to solve the problem but just temporarily until next time it breaks

KazariEX · 2024-09-28T15:23:24Z

It is caused by hybrid mode.

cabal95 · 2024-10-18T23:06:25Z

Adding screenshots for clarity (we are also seeing this issue):

When hybrid mode is enabled:

When hybrid mode is disabled:

romansp · 2024-10-18T23:39:12Z

Noticed something similar as well. Though it's for single click occurrences highlight.

This feature is controlled via editor.occurrencesHighlight VS Code setting. After additional investigation:

"editor.occurrencesHighlight": "single" - works in .ts files, doesn't work in .vue files

"editor.occurrencesHighlight": "multiFile" - works in .ts and .vue files

VS Code:
Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0
Vue Extension v2.1.6. TS: 5.5.4, Hybrid mode enabled

Anything else I can provide to help resolve this?

I personally can't reproduce this anymore and it works well for me again. Since my previous comment VS Code was upgraded to 1.94.2 and TypeScript is now 5.6.3.

cabal95 · 2024-10-21T15:10:12Z

I personally can't reproduce this anymore and it works well for me again. Since my previous comment VS Code was upgraded to 1.94.2 and TypeScript is now 5.6.3.

Just re-tested and we are still seeing this issue with the volar-starter repo (and our own repos). VS Code 1.94.2 and TS 5.6.3. Double click highlight works in pure TypeScript files but not .vue files unless we turn off Hybrid mode.

Setting "editor.occurrencesHighlight" to "multiFile" does work - until you restart VS Code and then it stops working and you have to toggle the setting to "single" and back to "multiFile" to make it work again.

romansp · 2024-10-21T17:46:03Z

Sorry! Yes @cabal95 is correct and issue is still reproducible. I had "multiFile" enabled.

richmason · 2024-10-23T05:27:38Z

Same issue for me, when single clicking a symbol. It is not just the scrollbar though, it is that none of the occurrences in the code are highlighted AS WELL as the scrollbar.

VSCode 1.94.2, TypeScript 5.6.3 - Hybrid Mode enabled. Issue was introduced in VSCode 1.93

alexchexes · 2024-10-26T19:55:21Z

Everything worked well exactly one year ago. I took a break for a while, so does anyone know in which version it started? And what exactly do I need to roll back – the Vue extension or VSCode? Can't really work without occurrences highlighting because there's a lot of code to refactor. This is killing me.

richmason · 2024-10-28T09:29:40Z

Everything worked well exactly one year ago. I took a break for a while, so does anyone know in which version it started? And what exactly do I need to roll back – the Vue extension or VSCode? Can't really work without occurrences highlighting because there's a lot of code to refactor. This is killing me.

I find that if I roll back VSCode to 1.92.x, it works again.

alexchexes · 2024-11-17T20:18:33Z

I find that if I roll back VSCode to 1.92.x, it works again.

It seems like we can just use the previous version of the Vue extension.

Does anyone know the potential drawbacks of using the 1.8.27 version of the extension while working with Vue 3.5.12?

rodrigocfd · 2025-01-23T19:09:42Z

Does anyone know the potential drawbacks of using the 1.8.27 version of the extension while working with Vue 3.5.12?

I just downgraded to 1.8.27, it works pretty good, and it also seems to be faster than current 2.2.0.

So yeah, that's what I'm using until this is fixed.

alexchexes · 2025-01-24T16:42:10Z

I just downgraded to 1.8.27

At first, I downgraded too, but then I noticed that the "Go to definition" feature doesn't work inside <template>, and some variable references didn’t work either. Eventually, I updated to the latest version (2.2.0 as of now) and, to make occurrences highlighting work, added this setting to my VS Code settings:

"vue.server.hybridMode": "typeScriptPluginOnly"

Now, 2.2.0 works pretty well. I haven’t noticed problems that I experienced before, yet, although I mainly work with JS, not TS right now.

artu-ole · 2025-03-10T14:19:24Z

@alexchexes I don't see how one can be happy with this unless it works differently on your computer. For me with "vue.server.hybridMode": "typeScriptPluginOnly" it highlights all same strings, but I expect it to highlight occurrences of the same identifier:

with hybrid mode	with typeScriptPluginOnly

It does still break for me after a restart on latest 2.2.8 until editor.occurrencesHighlight is toggled to singleFile and back to multiFile again.

johuhype added the pending triage label Sep 17, 2024

KazariEX added bug Something isn't working 🍰 p2-nice-to-have and removed pending triage labels Sep 20, 2024

KazariEX mentioned this issue Sep 20, 2024

The same variable should have the highlight #4861

Closed

KazariEX mentioned this issue Sep 28, 2024

VSCode "occurrencesHighlight" feature doesn't work for .vue files (regression) #4895

Closed

KazariEX mentioned this issue Nov 8, 2024

Word highlight does not work for vue files #4995

Closed

KazariEX mentioned this issue Dec 28, 2024

vue内点击变量不会自动高亮代码？降级到1.8版本就可以 #5093

Closed

KazariEX marked this as a duplicate of #5133 Jan 17, 2025

KazariEX removed the bug Something isn't working label Jan 18, 2025

KazariEX linked a pull request Mar 10, 2025 that will close this issue

fix(language-service): add document highlights support #5263

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Double click to show all occurrences in scrollbar is broken #4850

Double click to show all occurrences in scrollbar is broken #4850

johuhype commented Sep 17, 2024 •

edited

Loading

romansp commented Sep 19, 2024 •

edited

Loading

ddenev commented Sep 22, 2024

KazariEX commented Sep 28, 2024

cabal95 commented Oct 18, 2024

romansp commented Oct 18, 2024

cabal95 commented Oct 21, 2024

romansp commented Oct 21, 2024

richmason commented Oct 23, 2024

alexchexes commented Oct 26, 2024

richmason commented Oct 28, 2024

alexchexes commented Nov 17, 2024

rodrigocfd commented Jan 23, 2025

alexchexes commented Jan 24, 2025 •

edited

Loading

artu-ole commented Mar 10, 2025

Double click to show all occurrences in scrollbar is broken #4850

Double click to show all occurrences in scrollbar is broken #4850

Comments

johuhype commented Sep 17, 2024 • edited Loading

Vue - Official extension or vue-tsc version

VSCode version

Vue version

TypeScript version

System Info

package.json dependencies

Steps to reproduce

What is expected?

What is actually happening?

Link to minimal reproduction

Any additional comments?

romansp commented Sep 19, 2024 • edited Loading

ddenev commented Sep 22, 2024

KazariEX commented Sep 28, 2024

cabal95 commented Oct 18, 2024

romansp commented Oct 18, 2024

cabal95 commented Oct 21, 2024

romansp commented Oct 21, 2024

richmason commented Oct 23, 2024

alexchexes commented Oct 26, 2024

richmason commented Oct 28, 2024

alexchexes commented Nov 17, 2024

rodrigocfd commented Jan 23, 2025

alexchexes commented Jan 24, 2025 • edited Loading

artu-ole commented Mar 10, 2025

johuhype commented Sep 17, 2024 •

edited

Loading

romansp commented Sep 19, 2024 •

edited

Loading

alexchexes commented Jan 24, 2025 •

edited

Loading