Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug : aside style error caused by banner #2571

Closed
heygsc opened this issue Nov 15, 2023 · 1 comment · Fixed by #2572
Closed

bug : aside style error caused by banner #2571

heygsc opened this issue Nov 15, 2023 · 1 comment · Fixed by #2572

Comments

@heygsc
Copy link
Contributor

heygsc commented Nov 15, 2023

image




When the banner above exists, a small part of the aside will be missing.






image




If we close the banner, it will display as normal.




image

Open console, It can be observed,
increasing the "top" value, in the style of the "aside-container"class,
may fix this error.

This bug may not be related to this repo, or it may be related to the "vitepress".

In fact, through the package.json file, it can be found that the version of "vitepress" is not the latest version.
Currently, "aside-container" class in this repo is "position:sticky", and in a commit of "vitepress" (vuejs/vitepress@aecdeb9 ) , it has been changed to "fixed".

So I'm not sure if it's a problem with this repo,or with "vitepress" at the moment.

Welcome team members and others to to share their ideas.
I am happy to fix it with a PR. 😂

@brc-dd
Copy link
Member

brc-dd commented Nov 15, 2023

Nah that --vt-banner-height should be set to 70px. That vue mastery PR probably missed that. Contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants