Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DevTools's color scheme will conflict with the color scheme of the project itself #233

Closed
hooray opened this issue Feb 5, 2024 · 7 comments · Fixed by #339
Closed

Comments

@hooray
Copy link

hooray commented Feb 5, 2024

I see that DevTools adds light/dark class name to the HTML tag when switching color scheme, but there are some UI component libraries that also do color scheme switching via light/dark on the HTML tag, which results in switching color schemes in devtools and the current project's color scheme being affected.

I think DevTools should be given a different class name, such as devtools-light/devtools-dark

Kapture.2024-02-06.at.03.15.54.mp4
@webfansplz
Copy link
Member

That's by design. We prefer that the theme be as consistent as possible, follow the system, and be as consistent as possible with the user application environment.

@javatong
Copy link

I was messed up because I always thought there was a problem with my @vue/use. After following all the code, I found that it still automatically follows the system to change the dark mode. Finally, I had no choice but to build a new project and found that removing vite-plugin-vue-devtools plugin would not automatically change it

@webfansplz
Copy link
Member

Also be related to #111 (comment)

@webfansplz
Copy link
Member

I agree that we should isolate and avoid app conflicts with users as much as possible.

@webfansplz webfansplz reopened this Apr 15, 2024
@javatong
Copy link

Thank you for your reply. Looking forward to the new version

@LoTwT
Copy link
Contributor

LoTwT commented Apr 16, 2024

Hi, there.

What about adding some options to control whether the themes between the user project and the overlay injected by the Vite plugin should be the same?

I prefer the themes to be the same wherever I change them, while some projects don't use Vueuse or the developers expect them to be isolated. Could it be an enhancement?

@javatong
Copy link

Hi, there.

What about adding some options to control whether the themes between the user project and the overlay injected by the Vite plugin should be the same?

I prefer the themes to be the same wherever I change them, while some projects don't use Vueuse or the developers expect them to be isolated. Could it be an enhancement?

Good idea, I think so too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants