-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMR doesn't work for NPM library components that are appended to a slot #5767
Comments
Correction: this phenomenon doesn't only happen with Vite. The same test library built with @vue/cli exhibits identical behavior. |
@lingosandi the |
I've uploaded the code, thanks for catching that |
I am also having this issue in Vite. I get the |
In the same problem, I use elements-plus, the console has hmr log, but the page will not be updated |
Same issue. Using Quasar + Windi + Vite |
Using PrimeVue 3's One workaround I did was to add |
I've had the same issue with nuxt3 + vite + vuetify. |
It didn't work for me (vue 3 + vite) |
Same problem with vue 3 + vite + primevue |
Have the same issue, currently doing a migration vue 2 -> 3, application is in compat mode. We have vite 3 + vue 3, polling also doesn't work. |
For me the solution by @MilkoEmanuilov worked. But it updates much slower than before. |
I tried it too, but it didn’t work for me. |
Exactly the same thing happens to me too. This solution: Versions: |
I was playing a bit with the example (https://stackblitz.com/edit/vite-auuvqt?file=src%2Fcomponents%2FWrapper.vue) and I discovered that if the properties are associated to a ref variable, the hmr always works, but not with a value expressed in the template This was what I tried and works: The Child component with its associated aPropRef property is correctly updated in the browser if its value is changed in <script setup>. Another test I did: I hope this helps |
This has been fixed by #4077 (>=3.2.38) |
This issue still persist vue 3.2.45 Is there any workarround? |
Same for me too, the probleme is still here: |
he same problem with Hot reload not updating vue 3.2.45 I changed the vue to version 3.2.38 and it solved |
the issue is still there using the latest version of vue , not using any libray just changing a prop does not hot reload anything
|
Version
3.2.33
Reproduction link
github.com
Steps to reproduce
What is expected?
HMR should update the child component when props are changed, just like it does for the parent component
What is actually happening?
HMR fails to update the child component
this phenomenon doesn't occur during dev. It only appears when a library is build using Vite's library mode and uploaded to NPM, and is installed by a client. This presents a huge problem for library authors. You can find the source code and build settings of the test library from here: https://github.com/lingo3d/vue3-bug-example
The text was updated successfully, but these errors were encountered: