Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared): missed Symbol judge in looseEqual #3553

Merged
merged 1 commit into from
May 10, 2022
Merged

fix(shared): missed Symbol judge in looseEqual #3553

merged 1 commit into from
May 10, 2022

Conversation

conwnet
Copy link
Contributor

@conwnet conwnet commented Apr 7, 2021

https://github.com/vuejs/vue-next/blob/4fe4de0a49ffc2461b0394e74674af38ff5e2a20/packages/shared/src/looseEqual.ts#L12

I think the looseEqual function of above code should work like this:
looseEqual(Symbol('a'), Symbol('a')) // false

But looseEqual(Symbol('a'), Symbol('a')) returns true now.

@conwnet conwnet force-pushed the fix/looseEqual branch 3 times, most recently from 97b8dd2 to 934ccdd Compare April 7, 2021 09:55
@yyx990803 yyx990803 merged commit 0aeb4bc into vuejs:main May 10, 2022
iwusong pushed a commit to iwusong/core that referenced this pull request May 13, 2022
@conwnet @iwusong
fix(shared): missed Symbol judge in looseEqual (vuejs#3553)
7c11fbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conwnet @yyx990803