Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): support mounting app to svg container #2929

Merged
merged 4 commits into from
Mar 1, 2021
Merged

fix(runtime-dom): support mounting app to svg container #2929

merged 4 commits into from
Mar 1, 2021

Conversation

HcySunYang
Copy link
Member

close: #2926

@posva posva mentioned this pull request Jan 4, 2021
Closed
@LinusBorg LinusBorg added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Jan 6, 2021
@LinusBorg
Copy link
Member

@posva can this be approved now?

@posva
Copy link
Member

posva commented Jan 7, 2021

I think it's good but I'm not sure, that's why I didn't review it 😅
It looks a bit weird to pass isSVG as a parameter because it might not be the only kind of element needing a specific check, but this could also be refactored in the future with an enum if multiple types checks are needed

@LinusBorg LinusBorg added the need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. label Feb 1, 2021
@LinusBorg
Copy link
Member

LinusBorg commented Feb 5, 2021 •
edited
Loading

@yyx990803 We might need your input here as well.

@yyx990803 yyx990803 merged commit 8ffcde2 into vuejs:master Mar 1, 2021
@LinusBorg LinusBorg removed the need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. label Mar 12, 2021
@b2nil b2nil mentioned this pull request Mar 31, 2021
Merged
20 tasks
fangbinwei added a commit to fangbinwei/vue-cli that referenced this pull request Apr 5, 2021
@fangbinwei
fix(mocha): workaround the SVGElement issue in Vue
968c42e 
related to vuejs/core#2929
@fangbinwei fangbinwei mentioned this pull request Apr 5, 2021
Merged
9 tasks
haoqunjiang pushed a commit to vuejs/vue-cli that referenced this pull request Apr 6, 2021
@fangbinwei
fix(mocha): workaround the SVGElement issue in Vue (#6400)
7838c0d 
related to vuejs/core#2929
jeneser pushed a commit to jeneser/vue-cli that referenced this pull request Apr 11, 2021
@fangbinwei @jeneser
fix(mocha): workaround the SVGElement issue in Vue (vuejs#6400)
f3b8baa 
related to vuejs/core#2929
haoqunjiang pushed a commit to vuejs/vue-cli that referenced this pull request May 7, 2021
@fangbinwei @haoqunjiang
fix(mocha): workaround the SVGElement issue in Vue (#6400)
b39726e 
related to vuejs/core#2929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva left review comments

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App instance cannot render inside larger SVG
4 participants
@HcySunYang @LinusBorg @posva @yyx990803