Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactivity): store value cache on CustomRefs impls #11539

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

alexzhang1030
Copy link
Member

VueDevtools will access refs value to display on the devtools panel.

ref has its own _value, but customRefs are not (like customRef() or toRef(). Implementing a value cache is necessary to prevent potential side-effects or performance issues when VueDevtools reads these values.

Copy link

github-actions bot commented Aug 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.4 kB (+8.18 kB) 37.3 kB (+2.72 kB) 33.6 kB (+2.39 kB)
vue.global.prod.js 156 kB (+9.15 kB) 57 kB (+2.98 kB) 50.7 kB (+2.58 kB)

Usages

Name Size Gzip Brotli
createApp 53.9 kB (+4.29 kB) 20.9 kB (+1.43 kB) 19.1 kB (+1.31 kB)
createSSRApp 57.9 kB (+4.64 kB) 22.5 kB (+1.56 kB) 20.5 kB (+1.41 kB)
defineCustomElement 58.5 kB (+6.61 kB) 22.4 kB (+2.15 kB) 20.4 kB (+1.9 kB)
overall 67.5 kB (+4.34 kB) 25.9 kB (+1.45 kB) 23.6 kB (+1.32 kB)

@yyx990803 yyx990803 changed the base branch from main to minor August 7, 2024 03:53
@yyx990803 yyx990803 changed the base branch from minor to main August 7, 2024 03:54
@yyx990803 yyx990803 changed the base branch from main to minor August 7, 2024 14:11
@yyx990803 yyx990803 merged commit e044b6e into vuejs:minor Aug 7, 2024
7 checks passed
@alexzhang1030 alexzhang1030 deleted the feat/ref branch August 8, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants