Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somethings not right about @vue/runtime-dom 3.4.15 #10156

Closed
bayramorhan opened this issue Jan 19, 2024 · 12 comments
Closed

Somethings not right about @vue/runtime-dom 3.4.15 #10156

bayramorhan opened this issue Jan 19, 2024 · 12 comments
Labels
need more info Further information is requested

Comments

@bayramorhan
Copy link

bayramorhan commented Jan 19, 2024

Vue version

3.x

Link to minimal reproduction

https://play.vuejs.org/#eNp9kUFLwzAUx7/KM5cqzBXZbXQDlYF6UFHBSy6je+sy0yQkL3NQ+t19SdncYezW9//9X/pL24l758a7iGIqqlB75QgCUnRzaVTrrCfowOMaelh720LB1UIaaWprAkEbGpglfl08odYWvq3Xq6viRpqqHI7jg3ggbJ1eEvIEUG3u5l2Xl/u+KnnKqTIuEuxuW7tCPZOCuRRQMqzKk30xEhT49WvVjLfBGjbv0r4UtW2d0ujfHCnWk2IKmSS2ZLvfl5yRjzg65PUG658z+TbsUybFu8eAfodSHBktfYM04MXnK+75+QjZPmpuX4AfGKyOyXGoPUSzYu2TXrZ9zt9fmeYrLPaEJhwulURTs899KfifPF64+r/uZDzJe9L0ov8DExSnNA==

Steps to reproduce

Install latest vue 3.x and @vue/runtime-dom 3.4.15 and any version of Nuxt 3.x
Create some pages that will be rendered on the client side
Try to navigate between routes.

What is expected?

I expect not to get any errors while navigating around the app on client side.

Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'node.parentNode')

What is actually happening?

Im not totally sure if it's a vue 3.4.15 or vue/runtime-dom 3.4.15 bug. But all of my apps are broken after latest update on @vue/runtime-dom. Im using vue 3.x with Nuxt 3.9.x . Every time I try to navigate between routes, @vue/runtime-dom throwing an err
Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'node.parentNode')
The only thing that resolves this issue is downgrading vue version to 3.3.x or downgrading runtime-dom version to earlier versions. And you won't probably get this error until delete .nuxt folder and install everything from scratch. Because when you do that, all your packages will be updated to their latest versions. And everything will be broken. And I m pretty sure it's vue core bug and not related with Nuxt since I only get this error on CSR client side rendering. Don't forget if I downgrade to earlier versions of vue or runtime-dom, the error is gone.

System Info

You will get this error on any system and browser.

Any additional comments?

Sorry for reproduce link (its empty vue app) I m going to add real reproduce link very soon. I just wanted to share this problem because it feels like a major thing that needs to be checked immediately.

@daniluk4000
Copy link

I also have weird issues with teleport replacing root node.

@bayramorhan
Copy link
Author

I also have weird issues with teleport replacing root node.

Please let me know if my solution also works for your issue.

@typed-sigterm
Copy link

typed-sigterm commented Jan 19, 2024

+1 also appeared in my Nuxt project when use navigateTo 3 times in one tick.

@felixxxxxs
Copy link

+1 Bug is still present in Vue 3.4.15
This bug also showed up in my Nuxt project after updating dependencies (Nuxt to v3.9.x, which updated Vue to v3.4.x).
Pinning Vue to v3.3.13 resolved the issue.

@bayramorhan
Copy link
Author

bayramorhan commented Jan 19, 2024

+1 Bug is still present in Vue 3.4.15 This bug also showed up in my Nuxt project after updating dependencies (Nuxt to v3.9.x, which updated Vue to v3.4.x). Pinning Vue to v3.3.13 resolved the issue.

By the way I realised thta we dont need to downgrade all the way down to 3.3.x. Vue 3.4.2 is also works fine. This way we can get rid of the error and get benefits from vue 3.4

@felixxxxxs
Copy link

By the way I realised thta we dont need to downgrade all the way down to 3.3.x. Vue 3.4.2 is also works fine. This way we can get rid of the error and get benefits from vue 3.4

I can use Vue up to v3.4.8.
v3.4.9 and higher produce the errors
image
image
which cause the Nuxt navigation to stop working.

@bayramorhan
Copy link
Author

By the way I realised thta we dont need to downgrade all the way down to 3.3.x. Vue 3.4.2 is also works fine. This way we can get rid of the error and get benefits from vue 3.4

I can use Vue up to v3.4.8. v3.4.9 and higher produce the errors image image which cause the Nuxt navigation to stop working.

Thank you @felixxxxxs . 3.4.2 was enough for me so I didnt try every other vue versions up to 3.4.15. But I'm going to install 3.4.8 if its working fine as you said.

@ferferga
Copy link
Contributor

Related to #10098

More insights: #10098 (comment)

@haoqunjiang haoqunjiang added the need more info Further information is requested label Jan 20, 2024
@haoqunjiang
Copy link
Member

Thanks for submitting this issue! Due to our limited time, we ask you to include a reproduction link to a minimal full reproduction of your problem (for example, in a GitHub repository) so we can find what is causing the issue. Thank you for your understanding!

@gbyesiltas
Copy link

Same here ✋ I also get this error sometimes trying to navigate on Nuxt 3

@ferferga
Copy link
Contributor

ferferga commented Jan 22, 2024

As it's been reopened, this issue is now a duplicate of #10098

PR fixing this: #10184

@LinusBorg
Copy link
Member

duplicate #10098

@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need more info Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants