From 603a1e1f5ad587c077f0d974c1bbe856be22ebe9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Carmona?= Date: Tue, 13 Feb 2024 04:54:59 +0100 Subject: [PATCH] perf(runtime): improve `getType()` GC and speed (#10327) --- packages/runtime-core/src/componentProps.ts | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/packages/runtime-core/src/componentProps.ts b/packages/runtime-core/src/componentProps.ts index d1822a1638d..2d91affe082 100644 --- a/packages/runtime-core/src/componentProps.ts +++ b/packages/runtime-core/src/componentProps.ts @@ -597,8 +597,23 @@ function validatePropName(key: string) { // use function string name to check type constructors // so that it works across vms / iframes. function getType(ctor: Prop): string { - const match = ctor && ctor.toString().match(/^\s*(function|class) (\w+)/) - return match ? match[2] : ctor === null ? 'null' : '' + // Early return for null to avoid unnecessary computations + if (ctor === null) { + return 'null' + } + + // Avoid using regex for common cases by checking the type directly + if (typeof ctor === 'function') { + // Using name property to avoid converting function to string + return ctor.name || '' + } else if (typeof ctor === 'object') { + // Attempting to directly access constructor name if possible + const name = ctor.constructor && ctor.constructor.name + return name || '' + } + + // Fallback for other types (though they're less likely to have meaningful names here) + return '' } function isSameType(a: Prop, b: Prop): boolean {