Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dayjs): cannot handle week and quarter String + Format #6385

Merged
merged 8 commits into from
Apr 5, 2023

Conversation

CCherry07
Copy link
Member

@CCherry07 CCherry07 commented Mar 24, 2023

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
    初始化week WeekPicker 时,存在 valueFormat 无法正常,显示日期,原因是 dayjs 目前无法处理 输入字符串包含周的格式,来解析日期。
  2. Resolve what problem.
    https://day.js.org/docs/en/parse/string-format
    dayjs 目前无法处理 输入字符串包含周的格式,来解析日期。
  3. Related issue link.
    In a-range-picker week mode, the binding formatted date display error #6384

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

components/vc-picker/generate/dayjs.ts Outdated Show resolved Hide resolved
components/vc-picker/generate/dayjs.ts Outdated Show resolved Hide resolved
@CCherry07 CCherry07 changed the title fix(dayjs): cannot handle week's String + Format fix(dayjs): cannot handle week and quarter String + Format Mar 28, 2023
@CCherry07 CCherry07 requested a review from tangjinzhou March 28, 2023 15:18
@zkwolf
Copy link
Member

zkwolf commented Mar 29, 2023

snapshot看change感觉不太对?咋变成只有一个了

@CCherry07
Copy link
Member Author

不好意思,当时跑测试时,给注释了一个demo @zkwolf

@tangjinzhou tangjinzhou added the Accept You are right, we should do that label Apr 5, 2023
@tangjinzhou tangjinzhou merged commit 1977074 into vueComponent:main Apr 5, 2023
@CCherry07 CCherry07 deleted the fix-6384 branch April 23, 2023 16:58
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accept You are right, we should do that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants