fix: select auto location #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjinzhou
reviewed
Jul 28, 2022
| @@ -106,7 +106,7 @@ export default function useScrollTo( | |||
| }); | |||
| }; | |||
|
|
|||
| syncScroll(3); | |||
| syncScroll(5); | |||
There was a problem hiding this comment.
这个改动原因是什么
3的话，我发现第一次出现的时候，高度会对不上
There was a problem hiding this comment.
这个改动原因是什么
就是没有精确聚焦到active的那一项
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug address(select no positioning): https://codesandbox.io/s/hardcore-mountain-pmfhl5?file=/src/App.vue
When I use the Select component，Automatic location is disabled when you discover that fieldNames is used
This is fixed to value，this is wrong，This will cause problems with passing fieldNames。
I'm done with the test，It's time to submit the code
thx
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)