feat(store-ui): Add Modal molecule #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 70cd8a6 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/61532cdd2aeb710007124238 😎 Browse the preview: https://deploy-preview-957--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 70cd8a6:
|
igorbrasileiro
force-pushed
the
feat/modal
branch
3 times, most recently
from
ee903f5 to
4ff04a8
Compare
lariciamota
reviewed
Sep 17, 2021
igorbrasileiro
force-pushed
the
feat/modal
branch
from
b00490c to
ac53d1f
Compare
|
@icazevedo, does this last change make the component nearer to inversion control? |
icazevedo
reviewed
Sep 22, 2021
|
Forgot to comment here: excellent PR! Really great separation between pure and behavioral components 👏 |
victorhmp
approved these changes
Sep 23, 2021
icazevedo
approved these changes
Sep 23, 2021
icazevedo
approved these changes
Sep 23, 2021
igorbrasileiro
force-pushed
the
feat/modal
branch
from
3679ce7 to
b4bc474
Compare
igorbrasileiro
requested review from
icazevedo,
lariciamota and
emersonlaurentino
lariciamota
approved these changes
Sep 27, 2021
Co-authored-by: Ícaro Azevedo <icaro.azevedo@vtex.com.br>
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
igorbrasileiro
force-pushed
the
feat/modal
branch
from
ca142fc to
88881d3
Compare
icazevedo
reviewed
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Add the modal molecule, tests, and story.
closes #843
How it works?
How to test it?
References
Modal:
https://www.w3.org/TR/wai-aria-practices/#dialog_modal
https://github.com/reach/reach-ui/blob/main/packages/dialog/src/index.tsx
useTrapFocus:
https://github.com/reakit/reakit/blob/a211d94da9f3b683182568a56479b91afb1b85ae/packages/reakit/src/Dialog/__utils/useFocusTrap.ts#L31
Tests:
https://github.com/eps1lon/material-ui/blob/c0362a282ce17ff104048c5bd2cbaa4d7b367e10/packages/material-ui/src/Modal/Modal.test.js