Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-ui): slider #917

Merged
merged 17 commits into from
Aug 30, 2021
Merged

feat(store-ui): slider #917

merged 17 commits into from
Aug 30, 2021

Conversation

emersonlaurentino
Copy link
Member

What's the purpose of this pull request?

closes #835

localhost_6006__path=_story_atoms-slider--slider

How it works?

How to test it?

References

@emersonlaurentino emersonlaurentino self-assigned this Aug 23, 2021
@netlify
Copy link

netlify bot commented Aug 23, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: 3e2f791

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/612cf730028b8900084caa03

😎 Browse the preview: https://deploy-preview-917--storeui.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e2f791:

Sandbox Source
Store UI Typescript Configuration

Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible add these badges?
Screen Shot 2021-08-23 at 7 32 58 PM

@emersonlaurentino
Copy link
Member Author

Is it possible add these badges?
Screen Shot 2021-08-23 at 7 32 58 PM

No, it's not possible. but I think it's right because the value of the tooltip is the same as the below value (R$ 1.201.56).

It made me think that maybe we should have a Prefix to add the currency sign for example, or maybe a mask to format the value.

@victorhmp
Copy link
Member

@emersonlaurentino Not regarding the code itself yet, but I'm not sure about calling this component Slider since we're already using this name for the generic idea of a Carousel/Shelf, that's why there's the useSlider hook.

I had a quick chat with @lariciamota about this when she was looking into developing this, and we came up with the name Range for this component. How do you feel about that?

@emersonlaurentino
Copy link
Member Author

emersonlaurentino commented Aug 24, 2021

@emersonlaurentino Not regarding the code itself yet, but I'm not sure about calling this component Slider since we're already using this name for the generic idea of a Carousel/Shelf, that's why there's the useSlider hook.

I had a quick chat with @lariciamota about this when she was looking into developing this, and we came up with the name Range for this component. How do you feel about that?

I'm just following the w3 specification called Slider. You can read more about it here.

I think that's the right name and we must rename the useSlider to useCarousel. What do you think?

@victorhmp
Copy link
Member

I'm just following the w3 specification called Slider. You can read more about it here.

I think that's the right name and we must rename the useSlider to useCarousel. What do you think?

That's great! I didn't know that w3 had an official name for that, we should definitely follow it!

And sure! I agree, in this case we should rename the hook 😄

@emersonlaurentino emersonlaurentino marked this pull request as ready for review August 24, 2021 18:16
@emersonlaurentino emersonlaurentino requested a review from a team as a code owner August 24, 2021 18:16
@igorbrasileiro
Copy link
Contributor

Remember to add it to stores to see if it changes performance.

Copy link
Contributor

@igorbrasileiro igorbrasileiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @emersonlaurentino, nice documentation and component!
I left some comments and found a visual bug
image

@emersonlaurentino
Copy link
Member Author

@victorhmp @igorbrasileiro I apply your suggestions, can you review again?

packages/store-ui/src/atoms/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/store-ui/README.md Outdated Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Outdated Show resolved Hide resolved
packages/store-ui/src/atoms/Slider/Slider.tsx Show resolved Hide resolved
@emersonlaurentino emersonlaurentino merged commit 15a5f82 into master Aug 30, 2021
@emersonlaurentino emersonlaurentino deleted the feat/ui-range-slider branch August 30, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price Range
6 participants