-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store-ui): slider #917
Conversation
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 3e2f791 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/612cf730028b8900084caa03 😎 Browse the preview: https://deploy-preview-917--storeui.netlify.app |
7fc6979
to
b90d236
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e2f791:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emersonlaurentino Not regarding the code itself yet, but I'm not sure about calling this component Slider since we're already using this name for the generic idea of a Carousel/Shelf, that's why there's the I had a quick chat with @lariciamota about this when she was looking into developing this, and we came up with the name |
I'm just following the w3 specification called I think that's the right name and we must rename the |
That's great! I didn't know that w3 had an official name for that, we should definitely follow it! And sure! I agree, in this case we should rename the hook 😄 |
171ee4d
to
8a1f4ef
Compare
Remember to add it to stores to see if it changes performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @emersonlaurentino, nice documentation and component!
I left some comments and found a visual bug
821c9c0
to
5f8ca31
Compare
@victorhmp @igorbrasileiro I apply your suggestions, can you review again? |
What's the purpose of this pull request?
closes #835
How it works?
How to test it?
References