feat(store-ui): Adding select atom #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 9a8546a 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6123bd2e64163c0007024f63 😎 Browse the preview: https://deploy-preview-876--storeui.netlify.app |
bentoper
force-pushed
the
feat/select-atom
branch
from
ed6ddff to
b92bee1
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a8546a:
|
tlgimenes
previously requested changes
Aug 3, 2021
bentoper
force-pushed
the
feat/select-atom
branch
from
46ca71c to
da7957e
Compare
bentoper
force-pushed
the
feat/select-atom
branch
from
3f8a8f2 to
271355e
Compare
bentoper
force-pushed
the
feat/select-atom
branch
2 times, most recently
from
6f804c6 to
bbde42c
Compare
tlgimenes
previously requested changes
Aug 9, 2021
igorbrasileiro
suggested changes
Aug 9, 2021
There was a problem hiding this comment.
Nice job @bentoper ! Left some comments. Remember to update the stores with this breaking change, ok?!
bentoper
force-pushed
the
feat/select-atom
branch
4 times, most recently
from
47cc7d8 to
c42fa82
Compare
igorbrasileiro
approved these changes
Aug 11, 2021
|
Hey the preview seems not to be working https://deploy-preview-876--storeui.netlify.app/?path=/docs/atoms-select--default-select |
victorhmp
reviewed
Aug 12, 2021
bentoper
force-pushed
the
feat/select-atom
branch
from
15aa23b to
daf2a59
Compare
bentoper
force-pushed
the
feat/select-atom
branch
2 times, most recently
from
c8b466a to
984ff83
Compare
victorhmp
approved these changes
Aug 16, 2021
bentoper
force-pushed
the
feat/select-atom
branch
2 times, most recently
from
a9edb79 to
be51f41
Compare
bentoper
force-pushed
the
feat/select-atom
branch
from
be51f41 to
d8e9530
Compare
bentoper
dismissed
tlgimenes’s stale review
PR opened on all stores without any breaking changes
bentoper
force-pushed
the
feat/select-atom
branch
from
d8e9530 to
0c6bf24
Compare
Closed
bentoper
force-pushed
the
feat/select-atom
branch
2 times, most recently
from
9114a56 to
3f57c34
Compare
emersonlaurentino
approved these changes
Aug 23, 2021
added 19 commits
August 23, 2021 12:22
- extending the props from a different base
bentoper
force-pushed
the
feat/select-atom
branch
from
474a3a5 to
9a8546a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Adds the
Selectatom tostore-ui