feat(collections): Source collections from category tree #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: e0b1a54 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6103fde028a18400072b6035 😎 Browse the preview: https://deploy-preview-871--storeui.netlify.app |
tlgimenes
force-pushed
the
chore/cms-collections
branch
from
44e23c0 to
5723a7d
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0b1a54:
|
lariciamota
reviewed
Jul 29, 2021
lariciamota
reviewed
Jul 29, 2021
tlgimenes
force-pushed
the
chore/cms-collections
branch
from
ee9b278 to
3763e15
Compare
tlgimenes
force-pushed
the
chore/cms-collections
branch
from
3d20afa to
0ebc2dc
Compare
Co-authored-by: Larícia Mota <lmmc2@cin.ufpe.br>
igorbrasileiro
approved these changes
Jul 30, 2021
tlgimenes
commented
Jul 30, 2021
Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is the first iteration after this discussion #825 .
This PR makes
StoreCollectionto be sourced by@vtex/gatsby-source-vtexfor Brands/Categories. Also, this exports thePLPcontentType from the CMS and adds first class support to the catalog in the CMS plugin.How it works
@vtex/gatsby-source-vtexhas gained a new parameter. This parameter is called:sourceCollections. When this param is set, the plugin will list all categories/brands and create a correspondingStoreCollectionfor each.@vtex/gatsby-plugin-cmsnow exports a new contentType calledPLP. When sourcing data, ifgatsby-plugin-cmsencounters an instancePLP, it will get the correspondingStoreCollectionand add thisPLPas a foreign key ofStoreCollectionand add the corresponding SearchParams.In the end, the store will have the following schema:
Future Work
As you can see, this is only a partial implementation of what's described on #825 and requires more PRs to fully implement the RFC. I intend to do more PRs later to finish implementing the other use cases discussed on #825 and incremental builds. I didn't do all in one single PR because this would create a HUGE PR.
How to test it
The sole intent of this PR is to create new data to the Gatsby's data layer and nothing should change in any store having this version. Make sure this is the case for:
https://github.com/vtex-sites/storecomponents.store/pull/1060
https://github.com/vtex-sites/btglobal.store/pull/729
https://github.com/vtex-sites/marinbrasil.store/pull/572