Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-theme-store): Zip code persistence throughout the checkout flow. #802

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Jul 1, 2021

What's the purpose of this pull request?

Fixes zip code persistence throughout the checkout flow.

How it works?

Setting the zip code on the order form requires creating a new address for the user. However, for this use case, the isDIsposable field should be set to true, otherwise the behaviour is not well defined.

How to test it?

More on https://github.com/vtex-sites/carrefourbrfood.store/pull/875

References

@lbebber lbebber requested a review from a team as a code owner July 1, 2021 18:50
@netlify
Copy link

netlify bot commented Jul 1, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: e756f4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60df5f9fe0575500079e4d1b

😎 Browse the preview: https://deploy-preview-802--storeui.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e756f4f:

Sandbox Source
Store UI Typescript Configuration

@lbebber lbebber changed the title [WIP] Sets isDisposable as true on setRegion mutation Sets isDisposable as true on setRegion mutation Jul 2, 2021
Copy link
Contributor

@Gmantiqueira Gmantiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just don't forget to release with conventional commits

@lbebber lbebber force-pushed the fix/region-disposable-address branch from f6727fe to e756f4f Compare July 2, 2021 18:49
@Gmantiqueira Gmantiqueira changed the title Sets isDisposable as true on setRegion mutation fix(gatsby-theme-store): Zip code persistence throughout the checkout flow. Jul 5, 2021
@Gmantiqueira Gmantiqueira merged commit 46f65f8 into master Jul 5, 2021
@Gmantiqueira Gmantiqueira deleted the fix/region-disposable-address branch July 5, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants