Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title and description templates for product listing pages #2643

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

lariciamota
Copy link
Contributor

@lariciamota lariciamota commented Jan 28, 2025

What's the purpose of this pull request?

Use templates for title and description on PLP for SEO purposes.

How it works?

The store will be able to define their templates through the discovery.config.js file just like the example on discovery.config.default.js file in this PR.

How to test it?

Check if the metatags for title and description are being built correctly on a Collection page.
For example, for the Just Arrived collection on the storeframework account:

Before After
Screenshot 2025-01-28 at 16 33 51 Screenshot 2025-01-28 at 16 35 24

Starters Deploy Preview

https://storeframework-cm652ufll028lmgv665a6xv0g-omqh42rt5.b.vtex.app/ (PR)

References

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
faststore-site ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 7:25pm

Copy link

codesandbox-ci bot commented Jan 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@lariciamota lariciamota self-assigned this Jan 28, 2025
@lariciamota lariciamota added the enhancement New feature or request label Jan 28, 2025
@lariciamota lariciamota marked this pull request as ready for review January 28, 2025 19:36
@lariciamota lariciamota requested a review from a team as a code owner January 28, 2025 19:36
@lariciamota lariciamota requested review from hellofanny and pedromtec and removed request for a team January 28, 2025 19:36
Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screenshot 2025-01-28 at 17 36 45

@lariciamota lariciamota merged commit 00221d9 into main Jan 29, 2025
10 checks passed
@lariciamota lariciamota deleted the feat/collection-title-description branch January 29, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants