feat: Dynamically import BreadcrumbBase internal components
#2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lariciamota
requested review from
hellofanny and
eduardoformiga
and removed request for
a team
eduardoformiga
pushed a commit
that referenced
this pull request
Jan 15, 2025
## What's the purpose of this pull request? This PR is part of the performance initiative and aims to lazy load `BreadcrumbBase` internal components. ## How does it work? Since the `BreadcrumbBase` component is inside the `components` package, and Next isn't on this package, instead of using the `dynamic` function from `next/dynamic` it uses `lazy` and `Suspense` from React. ## How to test it? The breadcrumb should continue to work as before. The difference should be that the internal components (related to Dropdown) are dynamically imported. You can test it using the [preview](https://sfj-135f210--starter.preview.vtex.app/) and accessing the [Handmade Cotton Computer](https://sfj-135f210--starter.preview.vtex.app/handmade-cotton-computer-21395412/p) product, which has a long list of breadcrumbs - that way the breadcrumb gets collapsed and the Dropdown components are used. In the Network tab you'll be able to see a `Dropdown.<code>.js` - this doesn't happen on other pages that don't have a collapsed breadcrumb list. https://github.com/user-attachments/assets/20863bcb-14b8-4ad3-bf0d-a34c2cd75abd ### Starters Deploy Preview https://sfj-135f210--starter.preview.vtex.app/ ([PR](vtex-sites/starter.store#645)) ## References - [Jira task](https://vtex-dev.atlassian.net/jira/software/c/projects/SFS/boards/1051?selectedIssue=SFS-1860) - [`Next` doc: Lazy loading](https://nextjs.org/docs/pages/building-your-application/optimizing/lazy-loading)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is part of the performance initiative and aims to lazy load
BreadcrumbBaseinternal components.How does it work?
Since the
BreadcrumbBasecomponent is inside thecomponentspackage, and Next isn't on this package, instead of using thedynamicfunction fromnext/dynamicit useslazyandSuspensefrom React.How to test it?
The breadcrumb should continue to work as before. The difference should be that the internal components (related to Dropdown) are dynamically imported.
You can test it using the preview and accessing the Handmade Cotton Computer product, which has a long list of breadcrumbs - that way the breadcrumb gets collapsed and the Dropdown components are used.
In the Network tab you'll be able to see a
Dropdown.<code>.js- this doesn't happen on other pages that don't have a collapsed breadcrumb list.Screen.Recording.2025-01-09.at.10.32.20.mov
Starters Deploy Preview
https://sfj-135f210--starter.preview.vtex.app/ (PR)
References
Nextdoc: Lazy loading