feat: Filter with next/dynamic and lazy import
#2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
requested review from
lariciamota and
renatomaurovtex
and removed request for
a team
eduardoformiga
requested review from
a team,
renatamottam and
lucasfp13
and removed request for
renatomaurovtex,
a team and
renatamottam
lucasfp13
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR involves significant changes to the filter components within the
ProductGalleryand related files. The main goal is to refactor the filter functionality by removing theFiltercomponent and replacing it withFilterDesktopandFilterSlidercomponents. Additionally, dynamic imports are introduced to optimize loading.Key changes include:
Refactoring Filter Components:
Filtercomponent and its associated code fromFilter.tsx.FilterDesktop.tsxto include the GraphQL fragment previously inFilter.tsx.Filter,FilterFacetBoolean,FilterFacetBooleanItem,FilterFacetRange,FilterFacets, andFilterSliderinFilterSlider.tsx.index.tsto exportFilterDesktopandFilterSliderinstead of the removedFiltercomponent.Dynamic Imports:
ProductCard,EmptyGallery,FilterDesktop, andFilterSliderinDefaultComponents.ts.How to test it?
You can use the preview URL from the starter PR and double check that some JS are just loaded after Open the Filter in the mobile version.
https://sfj-d705510--starter.preview.vtex.app/office
Screen.Recording.2024-12-13.at.16.53.38.mov
Starters Deploy Preview
Filterwith next/dynamic vtex-sites/starter.store#638