feat: add new redirects feature #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Co-authored-by: Pedro Soares <32311264+pedromtec@users.noreply.github.com>
eduardoformiga
force-pushed
the
feat/redirect-in-get-static-props
branch
from
3ae0eaf to
86ce7da
Compare
pedromtec
changed the title
pedromtec
requested review from
hellofanny and
emersonlaurentino
and removed request for
a team
pedromtec
force-pushed
the
feat/redirect-in-get-static-props
branch
from
bedf1e0 to
017fc1f
Compare
lariciamota
approved these changes
Dec 13, 2024
eduardoformiga
approved these changes
Dec 13, 2024
pedromtec
commented
Dec 13, 2024
| } | ||
|
|
||
| const response = await fetch( | ||
| `https://${storeConfig.api.storeId}.myvtex.com/redirect-evaluate${pathname}` |
There was a problem hiding this comment.
We need to change this endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
The implementation of the redirects feature in FastStore appears as a strategic solution to facilitate the migration of old stores to our platform.
The idea of this feature is to run the redirect in the getStaticProps function when a certain page is not found. In other words, before rendering a not found (404) result to the user, we check if there is a redirect associated with the pathname requested by the user.
Since the pathname is not found (404). The redirect flow follows two steps. First it goes through a customization function called matcher. If the matcher cannot resolve the redirects, we validate whether a redirect exists in the rewriter database.
Components
Matcher: Optional function that can be implemented via customization. Some pathnames can be resolved via simple logic, without necessarily going to a database to check if there is a redirect registered. See an example.
Rewriter: If the redirect is not resolved via customization, a call will be made to the rewriter api to check if there is a redirect associated with the requested pathname.
Redirects RFC
How to test it?
https://storeframework.myvtex.com/admin/cms/redirects
We can run locally and try to access one of these redirects.
Example of matcher in starter: vtex-sites/starter.store#626
Example:
/produto/1