feat: add ads label product card #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hellofanny
requested review from
emersonlaurentino and
lariciamota
and removed request for
a team
lariciamota
reviewed
Dec 5, 2024
packages/components/src/molecules/ProductCard/ProductCardContent.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/molecules/ProductCard/ProductCardContent.tsx
Outdated
Show resolved
Hide resolved
hellofanny
changed the title
hellofanny
changed the title
lucasfp13
approved these changes
Dec 6, 2024
packages/components/src/molecules/ProductCard/ProductCardContent.tsx
Outdated
Show resolved
Hide resolved
eduardoformiga
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
LGTM!
I am just wondering if it would be better to wait until the IS issue is addressed so that we can prevent gaps among ProductGrids. WDYT?
Edit: my bad, I think we can merge once this PR is just related to the label and we have another task to address the issue.
hellofanny
changed the title
hellofanny
commented
Dec 9, 2024
| @@ -54,6 +54,10 @@ | |||
| --fs-product-card-wide-bkg-color : var(--fs-color-neutral-bkg); | |||
| --fs-product-card-wide-min-width : 9rem; | |||
|
|
|||
| // Sponsored Label | |||
There was a problem hiding this comment.
@mariana-caetano We've update these tokens, I've already created a task to update it :) Thanks https://vtex.slack.com/archives/C01664JGV43/p1733767718144659
emersonlaurentino
pushed a commit
that referenced
this pull request
Jan 10, 2025
## What's the purpose of this pull request? Enable Ad label indicator in `ProductCard`. Since products are duplicated in the Product Gallery, it's important to clearly indicate which products are sponsored. This will help prevent users from finding the duplication confusing. Additionally, we want to provide an easier way to customize the sponsored label. To achieve this, we're adding the label to the ProductCard and enable text customization via the CMS. |Before|After| |-|-| | TODO: - [ ] Run cms sync in the main account to reflect the `sections.json` changes. - [ ] Update `ProductCard` component doc with new tokens related to sponsored-label - I'll create a ticket when merging this PR - [x] Verifying with IS team if sponsored products should be included in the count parameter (it's a bug or feature) - current scenario setting the query with `count=12` its returning 13 products. [thread](https://vtex.slack.com/archives/C03L3CRCDC4/p1733413820077979?thread_ts=1733356825.821979&cid=C03L3CRCDC4) ## How it works? Changing the label via CMS, the default text is `Sponsored` |Admin|Store| |-|-| | ## How to test it? 1. Run the store locally 2. On `discovery.config.js`file, update `showSponsored` setting. ``` // Platform specific configs for API api: { ... showSponsored: true, } ``` 3. Change via CMS, you can use my test account [fannyads](https://fannyads--storeframework.myvtex.com/admin/new-cms/faststore/) - On the Product List Page: Look for Product Card Configuration, and update the `Sponsored Label` input. - Update the text and save. Use the [CMS mode preview](https://developers.vtex.com/docs/guides/faststore/headless-cms-previewing-changes-in-development-mode) to visualize the change in the store. - You should be able to see the Label with the text. ### Starters Deploy Preview [Preview Link - PLP](https://sfj-2e9ae6b--starter.preview.vtex.app/office?category-1=office&fuzzy=0&operator=and&facets=category-1%2Cfuzzy%2Coperator&sort=score_desc&page=0) [Test PR](vtex-sites/starter.store#628) ## References [Jira ticket](https://vtex-dev.atlassian.net/jira/software/c/projects/SFS/boards/1051?selectedIssue=SFS-1607) [Ad Network (Beta)](https://help.vtex.com/pt/tutorial/vtex-ad-network-beta--2cgqXcBuJmXN2livQvClur)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Enable Ad label indicator in
ProductCard.Since products are duplicated in the Product Gallery, it's important to clearly indicate which products are sponsored. This will help prevent users from finding the duplication confusing. Additionally, we want to provide an easier way to customize the sponsored label. To achieve this, we're adding the label to the ProductCard and enable text customization via the CMS.
TODO:
sections.jsonchanges.ProductCardcomponent doc with new tokens related to sponsored-label - I'll create a ticket when merging this PR - taskcount=12its returning 13 products. threadHow it works?
Changing the label via CMS, the default text is
SponsoredHow to test it?
discovery.config.jsfile, updateshowSponsoredsetting.Sponsored Labelinput.Starters Deploy Preview
Preview Link - PLP
Test PR
References
Jira ticket
Ad Network (Beta)