From 45c54e49019b90476e7829601ccf21b6e7ab0393 Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 15:23:03 -0300 Subject: [PATCH 1/8] Doc: Update PR template checklist --- pull_request_template.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index fcec8010..b7498afc 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -20,4 +20,14 @@ You may erase this after checking them all ;) -- [] CHANGELOG entry added +- [ ] CHANGELOG entry added. +- [ ] The latest version was added first in the `CHANGELOG.md`. +- [ ] PR number added in the CHANGELOG entry. + + +- PR +- [ ] Label added according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. +- [ ] The component, hook or pathname is in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. +- [ ] Function or parameter identified on the PR *- If applicable*. E.g.: `useWindowDimensions` hook. +- [ ] For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes. + From 6e78d15736a2f799f389d6c11fddaff9d042e71a Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 15:47:10 -0300 Subject: [PATCH 2/8] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 550d8aee..80d5ade4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Adds Storybook configs (#463) - Adds vtex search tracking script. With this we will populate TopSearches and Autocomplete indices (#389) - Add `RegionalizationBar`, `RegionalizationButton` components and integrates it on Mobile and Desktop devices (#424). +- New items in the `pull_request_template.md` ### Changed From 9a67c511cde90b071547862f677344cb59d29fbe Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 15:50:47 -0300 Subject: [PATCH 3/8] Update pull_request_template.md --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index b7498afc..4813a071 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -27,7 +27,7 @@ - PR - [ ] Label added according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. -- [ ] The component, hook or pathname is in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. +- [ ] The component, hook, or pathname is in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. - [ ] Function or parameter identified on the PR *- If applicable*. E.g.: `useWindowDimensions` hook. - [ ] For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes. From 1ce4b6943adf69cc2a570ba55631fa2897a87fb6 Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 17:23:33 -0300 Subject: [PATCH 4/8] Update pull_request_template.md Co-authored-by: Filipe W. Lima --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 4813a071..53bfa192 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -20,7 +20,7 @@ You may erase this after checking them all ;) -- [ ] CHANGELOG entry added. +- [ ] Add an entry in `CHANGELOG.md` at the beginning of its due section. [The latest version should comes first](https://keepachangelog.com/en/1.0.0/#:~:text=The%20latest%20version%20comes%20first.). - [ ] The latest version was added first in the `CHANGELOG.md`. - [ ] PR number added in the CHANGELOG entry. From 104ab823b6449f0249678d3f119a0d7f7000a0ef Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 17:39:30 -0300 Subject: [PATCH 5/8] Update pull_request_template.md --- pull_request_template.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 53bfa192..630d872f 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -20,14 +20,14 @@ You may erase this after checking them all ;) -- [ ] Add an entry in `CHANGELOG.md` at the beginning of its due section. [The latest version should comes first](https://keepachangelog.com/en/1.0.0/#:~:text=The%20latest%20version%20comes%20first.). -- [ ] The latest version was added first in the `CHANGELOG.md`. -- [ ] PR number added in the CHANGELOG entry. +- [ ] Added an entry in the `CHANGELOG.md` at the beginning of its due section. [The latest version should comes first](https://keepachangelog.com/en/1.0.0/#:~:text=The%20latest%20version%20comes%20first.). +- [ ] Added the PR number at the entry in the `CHANGELOG.md`. +- [ ] Updated the Storybook - *if applicable*. -- PR -- [ ] Label added according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. -- [ ] The component, hook, or pathname is in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. -- [ ] Function or parameter identified on the PR *- If applicable*. E.g.: `useWindowDimensions` hook. +- PR description +- [ ] Added a label according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. +- [ ] Added the component, hook, or pathname in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. +- [ ] Identified the function or parameter in the PR *- If applicable*. E.g.: `useWindowDimensions` hook. - [ ] For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes. From f21678f36bc1ef7e3e38309c88b9e721d6208e11 Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 17:40:57 -0300 Subject: [PATCH 6/8] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 80d5ade4..ce6a1da8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Added +- New items in the `pull_request_template.md` ([#12](https://github.com/vtex-sites/gatsby.store/pull/12)) - Integrates with search.query event api (#2) - Applies new local tokens to `Badge` (#462) - Applies new local tokens to `Hero` (#435) @@ -16,7 +17,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Adds Storybook configs (#463) - Adds vtex search tracking script. With this we will populate TopSearches and Autocomplete indices (#389) - Add `RegionalizationBar`, `RegionalizationButton` components and integrates it on Mobile and Desktop devices (#424). -- New items in the `pull_request_template.md` ### Changed From b5b78fdc1271ebc302e7909a944c1c7fcfa747b6 Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 17:43:38 -0300 Subject: [PATCH 7/8] Update pull_request_template.md --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 630d872f..09189d6e 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -22,10 +22,10 @@ - [ ] Added an entry in the `CHANGELOG.md` at the beginning of its due section. [The latest version should comes first](https://keepachangelog.com/en/1.0.0/#:~:text=The%20latest%20version%20comes%20first.). - [ ] Added the PR number at the entry in the `CHANGELOG.md`. -- [ ] Updated the Storybook - *if applicable*. - PR description +- [ ] Updated the Storybook - *if applicable*. - [ ] Added a label according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. - [ ] Added the component, hook, or pathname in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. - [ ] Identified the function or parameter in the PR *- If applicable*. E.g.: `useWindowDimensions` hook. From ee782d9e0ee4ae4327163e9fe5f3c6215632fedb Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Tue, 26 Apr 2022 18:36:47 -0300 Subject: [PATCH 8/8] Update pull_request_template.md --- pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 09189d6e..e165db90 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -21,13 +21,13 @@ You may erase this after checking them all ;) - [ ] Added an entry in the `CHANGELOG.md` at the beginning of its due section. [The latest version should comes first](https://keepachangelog.com/en/1.0.0/#:~:text=The%20latest%20version%20comes%20first.). -- [ ] Added the PR number at the entry in the `CHANGELOG.md`. +- [ ] Added the PR number with the PR link at the entry in the `CHANGELOG.md`. E.g., *New items in the `pull_request_template.md` ([#12](https://github.com/vtex-sites/gatsby.store/pull/12))* - PR description - [ ] Updated the Storybook - *if applicable*. - [ ] Added a label according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. -- [ ] Added the component, hook, or pathname in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component. -- [ ] Identified the function or parameter in the PR *- If applicable*. E.g.: `useWindowDimensions` hook. +- [ ] Added the component, hook, or pathname in-between backticks (``) *- If applicable*. E.g., *`ComponentName` component*. +- [ ] Identified the function or parameter in the PR *- If applicable*. E.g., *`useWindowDimensions` hook*. - [ ] For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes.