Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildRepoListing fails if no author object is defined in the manifest #13

Open
Markcreator opened this issue Apr 9, 2023 · 1 comment · May be fixed by #14
Open

BuildRepoListing fails if no author object is defined in the manifest #13

Markcreator opened this issue Apr 9, 2023 · 1 comment · May be fixed by #14

Comments

@Markcreator
Copy link

Markcreator commented Apr 9, 2023 •
edited
Loading

See here.

When using a package converted with the Package Maker Tool, it looks like the generated manifest contains no author object.
At no point is defining the author mentioned in the docs, nor exposed in the Unity Editor.

When following the instructions outlined in the package template using the converted package, building the repo listing will fail due to a null pointer exception because of the missing author object.
@momo-the-monster momo-the-monster linked a pull request Apr 10, 2023 that will close this issue
Checks whether author is null when trying to build package #14
Open
@momo-the-monster
Copy link
Collaborator

Thanks for the report, @Markcreator - I've linked PR #14 above which should patch this issue but I'm not sure that we should. Other parts of the ecosystem may expect an author to exist for a package. If so, we need to update the Package Builder to include an author field as well, so that our tools provide the right data from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checks whether author is null when trying to build package vrchat-community/package-list-action
2 participants
@momo-the-monster @Markcreator