Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NodeJS 8.x #323

Closed
andrewwippler opened this issue Sep 24, 2017 · 2 comments
Closed

Add support for NodeJS 8.x #323

andrewwippler opened this issue Sep 24, 2017 · 2 comments
Labels
needs-feedback Further information is requested

Comments

@andrewwippler
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: n/a
  • Ruby: n/a
  • Distribution: n/a
  • Module version: 3.1.0

Output log

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Var $repo_url_suffix with value '8.x' is not set correctly for CentOS 7.3.1611. See README.

Any additional information you'd like to impart

Add support for NodeJS 8.x https://github.com/nodejs/Release#release-schedule1

@juniorsysadmin juniorsysadmin added enhancement New feature or request and removed enhancement New feature or request labels Sep 25, 2017
@juniorsysadmin
Copy link
Member

Module version: 3.1.0

@andrewwippler I'm pretty sure this is not the behaviour in 3.1.0 since we stopped validating suffixes in #271 Did you mean 2.1.0?

@juniorsysadmin juniorsysadmin added the needs-feedback Further information is requested label Sep 26, 2017
@andrewwippler
Copy link
Author

Yep, it was me. The module was not updating because r10k needs a puppet/nodejs and I was giving it a puppet-nodejs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants