Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing dependency on puppetlabs-apt #172

Closed
ffrank opened this issue Oct 6, 2015 · 3 comments
Closed

Possibly missing dependency on puppetlabs-apt #172

ffrank opened this issue Oct 6, 2015 · 3 comments

Comments

@ffrank
Copy link
Contributor

ffrank commented Oct 6, 2015

On a fresh puppet install, the following manifest will not compile,

class {
    'nodejs':
        repo_url_suffix        => 'node_0.12',
        legacy_debian_symlinks => true;
}

Error is

Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::apt for node.example.net at /home/ff/.puppetlabs/etc/code/modules/nodejs/manifests/repo/nodesource/apt.pp:11:3 on node node.example.net

Puppet 4.2.3

@igalic
Copy link
Contributor

igalic commented Oct 14, 2015

it's weird that we hard-depend on

 {"name":"treydock/gpg_key","version_requirement":">=0.0.3 <1.0.0"}

but not on apt…

@juniorsysadmin
Copy link
Member

If it's just needed for one OS, the style guide defines that as a soft dependency that should be listed in the README (The soft dependencies should be made a lot clearer in the README though)

@ffrank
Copy link
Contributor Author

ffrank commented Nov 12, 2015

Oh right. It wouldn't make sense to pull that to yum machines. Closing.

@ffrank ffrank closed this as completed Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants